Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove removed flags from being used for v16+ binaries #12128

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Remove removed flags from being used for v16+ binaries #12128

merged 3 commits into from
Jan 25, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR removes the flags removed from v16 to be set on binaries from that and later releases. This change is required because we run upgrade-downgrade tests which spawn binaries from the next release too. So the flags removed in #12083 and #12085 have to be put behind a condition check to see if the spawned binary is from a version higher than 15 or not.

This PR makes these changes to fix the upgrade-downgrade tests which are currently broken as seen in https://github.com/vitessio/vitess/actions/runs/3949422838/jobs/6763433594

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
feat: remove enable_semi_sync and workflow flags from v16+
a33aaf4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Internal Cleanup Component: General Changes throughout the code base labels Jan 20, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 20, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 20, 2023 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

This was referenced Jan 20, 2023
Merged
Merged
@GuptaManan100
test: also fix test for ers initialization
f52e9b4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review January 20, 2023 16:58
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 20, 2023
deepthi
deepthi approved these changes Jan 24, 2023
View reviewed changes
go/test/endtoend/cluster/vtctld_process.go Outdated Show resolved Hide resolved
@GuptaManan100
tests: remove workflow manager flags entirely
409a0b5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 04dbcf7 into vitessio:release-15.0 Jan 25, 2023
@GuptaManan100 GuptaManan100 deleted the remove-removed-flags-15 branch January 25, 2023 04:25
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @harshit-gangal